fix(dashboard): post-merge fixes - quick-start, worker creds, check_skip - #1081
Merged
shiyiyue1102 merged 3 commits intoJul 28, 2026
Merged
Conversation
added 2 commits
July 26, 2026 20:19
Sync codex improvements and fix two issues found during review: Improvements (from codex): - Add AGENTTEAMS_QUICKSTART support in step_dashboard (aligns with AgentTeams main installer's quick-start mode) - Extract worker passwords/room IDs from workers-registry.json during upgrade credential extraction - Clean up agentteams-dashboard-data volume on uninstall - Probe gateway URL from inside controller container (same network as dashboard) with host fallback - Add check_skip() to verify.sh for semantically correct skip reporting - Use grep -qx for exact container name matching in verify.sh - Improve env file parsing (cut -d= -f2- | tr -d '\r') in verify.sh - Add Test 19 for quick-start step_dashboard execution Fixes: - Define missing check_skip() function in verify.sh (was used but never defined, causing 'command not found' at runtime) - Revert version-number normalization (strip-v) in dashboard.sh/ps1 to maintain consistency with install.sh (which expects v-prefixed versions). The strip-v logic was incomplete (not synced to install.sh) and not requested by maintainers. Test coverage: 47/47 passed (was 44/44).
- Update verify.sh comment to reflect 7 checks (was 6, dashboard check added) - Add curl/sleep mock to Test 18 to avoid polling real ports for 60s - Sync test file with dashboard repo for cross-repo consistency
Contributor
Author
|
@shiyiyue1102 这是 PR #1075 合并后的跟进 PR，包含合并时正在进行中的改进和修复。 背景PR #1075 在第五轮审查修复（提交 改动内容改进（来自 codex 审查）：
修复：
测试
请您审阅，感谢！ @shiyiyue1102 This is a follow-up PR after the merge of PR #1075, containing improvements and fixes that were in progress at the time of the merge. BackgroundPR #1075 was merged after the fifth round of review fixes (commit Change contentImprovements (from codex review):
Fix:
Test
Please review, thank you! |
shiyiyue1102
approved these changes
Jul 28, 2026
shiyiyue1102
left a comment
shiyiyue1102
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The Dashboard follow-up is aligned with the intended install and upgrade behavior. Verified at head 44bd4f93: the Dashboard regression suite passes 47/47, all modified shell scripts pass bash -n, and git diff --check is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #1075 (merged). Contains improvements that were in-flight when the original PR was merged.
Closes #1080 (continued)
Improvements (synced from codex review)
step_dashboardnow handlesAGENTTEAMS_QUICKSTART(aligns with main installer)workers-registry.jsonduring upgradeagentteams-dashboard-datavolume on uninstallcheck_skip()for semantically correct skip reporting; usegrep -qxfor exact container name matchingstep_dashboardBug fixes
check_skipbut never defined it — added function definitionUPGRADE_KEEP_ALLearly-return instep_dashboard; restored it since maintainers explicitly require keep-all upgrade to preserve dashboard configTest coverage
-A 40→-A 60) to accommodate longer functionTest plan
bash install/agentteams-dashboard-tests.sh— 47/47 passedbash -nsyntax check passed for all modified scripts